Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "preference" to "settings" #90

Merged
merged 6 commits into from Mar 20, 2023
Merged

Conversation

DivineDominion
Copy link
Collaborator

Changes occurrences of "preferences" to "settings" and almost finishes #76 -- renaming the source folder and README is not done here, yet.

@sindresorhus
Copy link
Owner

There's also:

While I'm doing that, also rename preferencePaneIdentifier to paneIdentifier and preferencePaneTitle to paneTitle

But I'm happy to do that if you don't want to do it in this PR.

@DivineDominion
Copy link
Collaborator Author

Will fix things over the weekend 👍

@sindresorhus
Copy link
Owner

Friendly bump :)

@DivineDominion
Copy link
Collaborator Author

@sindresorhus I'll resolve conflicts before merging, unless you prefer I rebase before you take a look

@sindresorhus
Copy link
Owner

Looks good. Feel free to merge.

@DivineDominion DivineDominion merged commit 0208443 into main Mar 20, 2023
@DivineDominion DivineDominion deleted the ctietze/settings-rename branch March 20, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants