Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NSMenu on macOS 14 #136

Merged
merged 6 commits into from Jul 16, 2023
Merged

Support NSMenu on macOS 14 #136

merged 6 commits into from Jul 16, 2023

Conversation

decodism
Copy link
Contributor

Fixes #135

After the latest beta broke keyUp, I also found that we could use CFRunLoopObserver.

@decodism
Copy link
Contributor Author

I don't know if it's correct, but I've written RunLoopLocalEventMonitor in a general way.

@decodism
Copy link
Contributor Author

I've added a short comment.

@sindresorhus sindresorhus merged commit 8b1a9ce into sindresorhus:main Jul 16, 2023
1 check passed
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support keyDown when NSMenu is open on macOS 14
2 participants
@decodism @sindresorhus