Persist the FPS setting

sindresorhus · Jan 30, 2022 · c8d0752 · c8d0752
1 parent de2dce3
commit c8d0752
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/Gifski.xcodeproj/project.pbxproj b/Gifski.xcodeproj/project.pbxproj
@@ -790,7 +790,7 @@
  repositoryURL = "https://github.com/firebase/firebase-ios-sdk";
  requirement = {
  kind = upToNextMajorVersion;
- minimumVersion = 8.10.0;
+ minimumVersion = 8.11.0;
  };
  };
 /* End XCRemoteSwiftPackageReference section */

diff --git a/Gifski/Constants.swift b/Gifski/Constants.swift
@@ -21,6 +21,7 @@ extension NSColor {
 extension Defaults.Keys {
  static let outputQuality = Key<Double>("outputQuality", default: 1)
  static let outputSpeed = Key<Double>("outputSpeed", default: 1)
+ static let outputFPS = Key<Int>("outputFPS", default: 10)
  static let loopGif = Key<Bool>("loopGif", default: true)
  static let bounceGif = Key<Bool>("bounceGif", default: false)
  static let suppressKeyframeWarning = Key<Bool>("suppressKeyframeWarning", default: false)

diff --git a/Gifski/EditVideoViewController.swift b/Gifski/EditVideoViewController.swift
@@ -320,6 +320,7 @@ final class EditVideoViewController: NSViewController {
  }
 
  let frameRate = self.frameRateSlider.integerValue
+ Defaults[.outputFPS] = frameRate
  self.frameRateLabel.stringValue = "\(frameRate)"
  self.estimatedFileSizeModel.updateEstimate()
  }
@@ -353,7 +354,7 @@ final class EditVideoViewController: NSViewController {
  frameRateSlider.maxValue = frameRate.clamped(to: Constants.allowedFrameRate)
 
  if isInit {
- frameRateSlider.doubleValue = defaultFrameRate(inputFrameRate: frameRate)
+ frameRateSlider.integerValue = Defaults[.outputFPS]
  }
 
  frameRateSlider.triggerAction()
@@ -626,10 +627,6 @@ final class EditVideoViewController: NSViewController {
  predefinedSizesDropdown.selectItem(at: 0)
  }
 
- private func defaultFrameRate(inputFrameRate frameRate: Double) -> Double {
- frameRate.clamped(to: Constants.allowedFrameRate.lowerBound...20)
- }
-
  private func getNaiveEstimate() -> Double {
  let duration: Double = {
  guard let timeRange = timeRange else {