Fix duplicated telemetry handler ids #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeartS
force-pushed
the
fix-duplicated-telemetry-handlers
branch
2 times, most recently
from
11f894b to
304b1a1
Compare
LeartS
force-pushed
the
fix-duplicated-telemetry-handlers
branch
from
304b1a1 to
8899007
Compare
|
Thank you for the PR @LeartS! Would you be able to update this with a test? https://github.com/SimpleBet/opentelemetry_commanded/blob/main/test/commanded/event_store_test.exs |
|
@LeartS ping |
|
Sorry! I'll get this prioritised this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry handlers were being registered with the same id, which resulted in only the first handler being actually attached, and all the others failing with
{:error, :already_exists}