Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YunoHost icon #10947

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

CodeShakingSheep
Copy link
Contributor

@CodeShakingSheep CodeShakingSheep commented May 13, 2024

image

Issue: closes #10920

Popularity metric:

The Similarwebrank is 269,570. See https://www.similarweb.com/website/yunohost.org

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Downloaded icon from https://techicons.dev/icons/yunohost , resized and combined path and rect.

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label May 13, 2024
{
"title": "YunoHost",
"hex": "000000",
"source": "https://icon.icepanel.io/Technology/svg/Yuno-Host.svg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is IcePanel an official source for YunoHost? I can't see anything on the homepage to suggest it is.
Looking at Yunohost's own documentation there is an SVG - but it's a horizontal one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, IcePanel is not really an official source for YunoHost. I just thought I could save some work here as on their official website, they just have a png, see https://yunohost.org. As I found the svg on IcePanel which looked fine I didn't want to manually vectorize the png icon from their website.

So, what would be the correct procedure here? Manually vectorize the png from the website or just change the source? Personally, I prefer the compact logo over the horizontal logo from their documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we'd find an official source (one of their websites, a Wikipedia entry, or a GitHub repo of theirs) and use that as a source. Failing that, we can compare the SVG you've found against the PNG - but the source should really come from the company themselves.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just redid the icon from the official source @Tagadda linked. Thanks for that!

@adamrusted
Copy link
Member

@CodeShakingSheep - please don't feel the need to merge develop into this unless you're making changes locally. Anyone that has left a comment or review gets pinged every time you do that. 😄

@CodeShakingSheep
Copy link
Contributor Author

I updated the icon from the official source. This is how it looks like.
image

Good with you @adamrusted ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: YunoHost
3 participants