Skip to content

feat: add spanish and crc currency #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

dnunnari
Copy link
Contributor

@dnunnari dnunnari commented Feb 12, 2025

Summary

Adds spanish locale and costa rican colon.

I made sure that:

  • I have read the contributing guidelines.
  • I have searched for a similar pull request.
  • The feature/bug-fix is tested carefully.
  • All irrelevant commits are squashed. (e.g. no chore: fix eslint commits).
  • The branch is up to date with the base branch.

@dnunnari dnunnari requested a review from simonwep as a code owner February 12, 2025 21:29
@dnunnari
Copy link
Contributor Author

@simonwep sorry, my fork was out of date and I ran into a lot of conflict issues, I thought it was easier to just sync back the fork and send a new PR. Thank you!

@simonwep
Copy link
Owner

@dnunnari no problem, thank you very much for your contribution!

@simonwep simonwep force-pushed the feat-add-spanish-and-crc branch from 4622c91 to 58bda2a Compare February 16, 2025 08:04
@simonwep simonwep added this to the v1.10.0 milestone Feb 16, 2025
@simonwep simonwep merged commit 1cd65ab into simonwep:main Feb 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants