Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Metadata to --internal database #2343

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

asg017
Copy link
Contributor

@asg017 asg017 commented May 6, 2024

Work-in-progress, not ready for review. refs #2341

  • Removes .metadata() and ._metadata() fields from the Datasette class
  • Removes /-/metadata.json endpoint
  • Removes metadata "fallback"
  • Removes the get_metadata() hook
  • Adds the following methods to Datasette:
    • get_instance_metadata()
    • get_database_metadata()
    • get_resource_metadata()
    • get_column_metadata()
    • set_instance_metadata()
    • set_database_metadata()
    • set_resource_metadata()
    • set_column_metadata()
  • Adds the following tables to internal.db
    • datasette_metadata_instance_entries
    • datasette_metadata_database_entries
    • datasette_metadata_resource_entries
    • datasette_metadata_column_entries

TODO

  • Support metadata.json
  • Don't change facet logic, move facet_size to synchronous config
  • Docs!

馃摎 Documentation preview 馃摎: https://datasette--2343.org.readthedocs.build/en/2343/

@asg017 asg017 marked this pull request as ready for review May 20, 2024 16:37
@simonw simonw self-requested a review May 21, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant