feat: collapsible mention section #1439
Open
+473
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zefhemel I noticed I missed fetching the latest merged changes – this has now been updated and should be ready to merge. I've also slightly improved the UI (buttons, icons, no more scrollbar etc.): 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this makes the whole mention section collapsible by clicking on the "Linked Mentions (2)" header (it is collapsed by default, could be changed). It also shows the total number of mentions (could be removed).
Rationale: If you have many mentions, it unnecessarily bloats the page.
Note: Mentions can be scrolled separately from the page. My thinking is that this allows easier back-and-forth between main content and references.
Note: There is no change to the loading behavior (posssible async loading etc.). I didn't investigate this because I never really had long loading times :)
Collapsed
Expanded
