Vim Mode and Read Only Fixes #1240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove client.focus call from global keydown handler. This call causes issues with vim mode. For instance typing j with the editor not focused would insert a j before properly going to normal mode instead of just moving down a line as expected - add client.reloadPage call to setUiOption syscall. This appears to fix read only mode that is broken without the above focus call. In particular when switching between vim and regular mode read only mode was previously broken even with the client.focus call - add client.focus call to CommandPalette onTrigger if no cmd is selected. Without the client.focus call above, the editor is no longer selected when exiting the command palette with escape - this call fixes that - add watch-all task to deno.json to run all 3 watches in 1 terminal window
zefhemel
requested changes
Feb 22, 2025
| @@ -47,6 +47,7 @@ | |||
| "watch-web": "deno run -A --check build_web.ts --watch", | |||
| "watch-server": "deno run -A --unstable-kv --unstable-worker-options --check --watch silverbullet.ts", | |||
| "watch-plugs": "deno run -A --check build_plugs.ts -w", | |||
| "watch-all": "deno task watch-web & deno task watch-server & deno task watch-plugs", | |||
There was a problem hiding this comment.
I'm ok with adding this, but then let's add deno task watch-server at the end so you can pass it arguments (like a folder), for instance deno task watch-all ~/tmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in vim mode if the editor isn't selected and I hit
jit will cause the editor to gain focus and insert the j character before entering vim normal mode. Read only mode is broken when toggling vim mode. This PR attempts to fix those issues. I don't know if there's a better way to fix the read only mode than calling reloadPage but it seems to workremove client.focus call from global keydown handler. This call is what breaks vim mode
add client.reloadPage call to setUiOption syscall. This appears to fix read only mode that is completely broken without the above focus call. It also seems to fix the issue when toggling vim mode
add client.focus call to CommandPalette onTrigger if no cmd is selected. Without the client.focus call above, the editor is no longer selected when exiting the command palette with escape - this call fixes that
add watch-all task to deno.json to run all 3 watches in 1 terminal window