New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keymaps feature #1594
Keymaps feature #1594
Conversation
The branch has been updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these things are still missing I believe for the feature to be complete
- while in the text editor,
esc
should leave the text edition - the titles on the buttons should inform the user that there is a shortcut - cf screenshot bellow
my feedback about the choice of shortcuts, to be discussed
- you where right, tab is a bad idea for preview, we do use tab for tab, sorry my bad
- I would avoid shortcuts with 2 modifiers when possible? e.g "Full panels" could be alt+ instead of shift+alt+?
-
esc
should close the last opened dialog - e.g. open publish, then esc, then close publish. Also right now it closes all pannels, e.g. i open the pages panel, then settings dialog, then esc => both are closed which is not what i intended (only settings should close) -
esc
in the settings when a text field is focused should close the settings, but instead it does nothing - good addition would be to pay attention to focus when a dialog opens (it is out of this feature I think, it should work also when open with a button), e.g. publish dialog focus the publish button
@lexoyo I added some functionality to my PR! ✅ There are shortcuts hints in the project bar buttons (including the Publish button). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've addressed the problems you raised:
- Being able to select the body with Escape when there is no context opened.
- Put back the autofocus of the first text input in a modal.
Description
This pull request brings several pre-defined, ready-to-use shortcuts.
Shortcuts list
Full panels
Left panels
Workflow-specific