-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Flake with nix derivation changes for easier extension of available Lua modules #2186
Conversation
I ran:
On the
Then I applied: diff --git i/build-aux/pkg.nix w/build-aux/pkg.nix
index 5d774f8e..79ae2d11 100644
--- i/build-aux/pkg.nix
+++ w/build-aux/pkg.nix
@@ -136,7 +136,6 @@ stdenv.mkDerivation (finalAttrs: {
luaPackages =
[
# modules used at runtime
- "cassowary"
"cldr"
"fluent"
"linenoise"
And got a different hash:
|
The eval is clearly different, but the problem is that the build succeeds either way. It should have failed completely when you removed cassowary as the configure phase should have determined that it was missing. |
Ah garumph. The flake builds either way but crashes at runtime instead. I hadn't tried that yet, so apparently the change is affecting the build, but something is wrong with the configure phase that should have thrown an error when it couldn't find the dependency. |
I see in the
|
I also see:
Which maybe related to NixOS/nixpkgs#361005 . |
And the build succeeds, but running the executable fails to find the modules I removed. |
Yes, I got that too (per my message above you might have missed, being busy composing one yourself). I just identified why I didn't figure that out sooner: at runtime it finds the cassowary installation from my host system when it can't find it in the flake. As SILE is designed for users/projects to add or override their own dependencies at runtime that is expected, it just made debugging this hard. That doesn't explain why it succeeds to build when it should not, but I'll look into that more. |
Your output is also suggesting that the LuaRocks manifests are not getting installed properly via |
Sooo, that turned out to be a bug in my autoconf macro code, not the Flake at all. |
Hey @doronbehar, my attempt to port the upstream packaging changes to the sile derivation to the flake here did not go quite as planned. It builds and runs, but it doesn't work as it should as evidenced by the fact that I can delete stuff in the
luaPackages
array and the build doesn't fail the configure stage where it should be detecting dependencies. That tells me the upstream package one is being used, not the locally defined one. I couldn't figue our the Nix language incantation to override the array in the passthru table and use it in the luaEnv at the same time.