Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: change to official NixOS wiki #2025

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented May 8, 2024

@Mic92 Mic92 requested a review from alerque as a code owner May 8, 2024 19:35
@Omikhleia Omikhleia added the documentation Documentation bug or improvement issue label May 8, 2024
@Omikhleia
Copy link
Member

Omikhleia commented May 10, 2024

Greetings,

  • SILE uses "conventional commits", so it seems to me that you should amend1 your commit so that it starts with chore(readme): Change to official NixOS wiki

  • Moreover the old wiki (https://nixos.wiki/wiki/Flakes#Installing_flakes, if I understand correctly), is also mentioned in the SILE manual (file documentation/c02-gettingstarted.sil). This would need to be fixed too, ideally is one more commit docs(manual): ...

  • Finally, there are a few .nix files in the repository mentioning https://nixos.wiki/wiki/Flakes#Using_flakes_project_from_a_legacy_Nix in comments. Shouldn't they be changed to use https://wiki.nixos.org/wiki/Flakes too? (But I can't find the referred section)

Footnotes

  1. E.g. git commit --amend, change the commit line and save, then git push --force

default.nix Outdated Show resolved Hide resolved
@Omikhleia
Copy link
Member

Omikhleia commented May 10, 2024

N.B. I'm not a maintainer - I've approved the PR in order for CI the tests to be run and reported.

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update links. Lets get the hash updated as well but otherwise LGTM.

default.nix Outdated Show resolved Hide resolved
default.nix Outdated Show resolved Hide resolved
@alerque alerque merged commit fbd8e68 into sile-typesetter:master May 28, 2024
14 checks passed
@Mic92 Mic92 deleted the patch-1 branch May 28, 2024 15:13
@alerque alerque added this to the v0.14.18 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation bug or improvement issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants