Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual compaction endpoint #7072

Merged
merged 4 commits into from
Mar 4, 2025

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Mar 4, 2025

For some reason manual finalization isn't triggering compaction. I'll try investigating, but in the meantime this PR introduces an endpoint that allows users to manually trigger background compaction.

Copy link

mergify bot commented Mar 4, 2025

This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏

@eserilev eserilev changed the title manual compaction endpoint Manual compaction endpoint Mar 4, 2025
@eserilev eserilev added v7.0.0-beta.2 Second hacky Holesky rescue release ready-for-review The code is ready for review labels Mar 4, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen merged commit 1b58597 into sigp:holesky-rescue Mar 4, 2025
24 checks passed
@michaelsproul michaelsproul mentioned this pull request Mar 5, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review v7.0.0-beta.2 Second hacky Holesky rescue release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants