Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 15 compatibility #39

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Angular 15 compatibility #39

merged 7 commits into from
Dec 12, 2023

Conversation

fanil-kashapov
Copy link

@fanil-kashapov fanil-kashapov commented Jul 7, 2023

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the new behavior?
Update to angular 15

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

@fh1ch fh1ch added the enhancement New feature or request label Jul 8, 2023
Copy link
Member

@fh1ch fh1ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fanil-kashapov thanks a ton for this great MR, we appreciate this a lot 🙇

A few general input/questions from my end, otherwise this one is good to go. Let me know what you think, back to you 🏓

.eslintrc.json Outdated Show resolved Hide resolved
angular.json Outdated Show resolved Hide resolved
src/app/app-routing.module.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Fanil Kashapov and others added 3 commits July 11, 2023 11:22
Copy link
Author

@fanil-kashapov fanil-kashapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for review, done

@siemens siemens deleted a comment from thatcort Dec 12, 2023
@siemens siemens deleted a comment from supremeqwert Dec 12, 2023
@siemens siemens deleted a comment from rampency Dec 12, 2023
Copy link
Member

@fh1ch fh1ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks for the rework and sorry for the delay here 🙇

All findings addressed and no new questions from my end, so let's get this released.

@fh1ch fh1ch merged commit a0249d7 into siemens:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants