docs: use the cilium-cli image repo in the job installation manifest #11092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the cilium-cli-ci image repo used for CI builds, with the recently added cilium-cli image repo intended for tagged releases. Signed-off-by: Brian Brookman <[email protected]> Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
docs/cilium-cli-image-repo
branch
from
7fc278c to
5d02240
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What? (description)
Replace the cilium-cli-ci image repo used for CI builds with the recently added cilium-cli image repo intended for tagged releases.
Why? (reasoning)
The cilium/cilium-cli-ci image is used for CI and is built and pushed on PR branches so breaking changes, bugs, and potential risks are more likely.
Disclaimer: I'm not a cilium maintainer or contributor, but found cilium/cilium-cli#2755 where the cilium-cli repo was proposed, and cilium/cilium-cli#2980 where the image push workflow was updated.
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)