Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addDefaultCallback can be set with refresh and local providers #710

Merged

Conversation

nojiritakeshi
Copy link
Contributor

πŸ”— Linked issue

#622
#656

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

addDefaultCallback can now be set by refresh and local provider.
I have confirmed that it works in playground.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@zoey-kaiser zoey-kaiser added enhancement An improvement that needs to be added provider-local An issue with the local provider provider-refresh An issue with the refresh provider labels May 9, 2024
@zoey-kaiser
Copy link
Member

Hi @nojiritakeshi πŸ‘‹

Thank you for your contribution, and I apologize for the delay! As this change is very straight forward and reuses logic from the AuthJS provider, I think we can quickly push this through and release it in 0.8.0!

Could you please fix the merge conflicts and then we can do a review and hopefully merge without any issues 😊

@nojiritakeshi
Copy link
Contributor Author

Hi @zoey-kaiser !
Thanks for the review.
Conflicts have been resolved, please check again.

Copy link
Member

@zoey-kaiser zoey-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nojiritakeshi πŸ‘‹
Sorry for the delay in the review, I have been pretty swamped lately πŸ˜“

Thanks for the awsome PR! Could you please look into making this new option configurable via the nuxt config, like with the authjs provider?

There we allow you to set addDefaultCallbackUrl to a boolean to enable / disable automatic callback URL detection or hard code it to a string, which is then always the callback URL?

I think this would allow for more flexibility and would also match the other providers! Thank you so much 😊

@nojiritakeshi
Copy link
Contributor Author

Hi @zoey-kaiser πŸ˜„

Indeed. I agree with that opinion.
I may take some time since I've been busy lately, but I'll try to find the time to fix it.

@nojiritakeshi
Copy link
Contributor Author

Hi @zoey-kaiser .
This modification is made so that the string set in the addDefaultCallback property in nuxt.config is applied to the callbackUrl.

There we allow you to set addDefaultCallbackUrl to a boolean to enable / disable automatic callback URL detection or hard code it to a string, which is then always the callback URL?

Therefore, I do not see the need to make a new correction to this point, do you?

Please let me know if I am misguided!

@zoey-kaiser zoey-kaiser changed the title addDefaultCallback can be set with refresh and local providers fix: addDefaultCallback can be set with refresh and local providers Jun 28, 2024
@zoey-kaiser zoey-kaiser merged commit 1d5a1a4 into sidebase:main Jun 28, 2024
4 checks passed
@zoey-kaiser
Copy link
Member

This modification is made so that the string set in the addDefaultCallback property in nuxt.config is applied to the callbackUrl.

You are right! I revised this PR and agree! Sorry about the confusion! Thank you for your contribution! I will release this PR in 0.8.0-rc.1 now! πŸ₯³

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement that needs to be added provider-local An issue with the local provider provider-refresh An issue with the refresh provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants