Refactor BinaryLogClient into an abstract base class to allow for more flexible use #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l over whether to stop the BinaryLogClient.
1. AbstractBinaryLogClient now no longer depends on EventListener or LifecycleListener. 2. LifecycleListener goes back to accepting BinaryLogClient arguments. Still haven't run tests.
…ica/Los_Angeles timezone, because of Daylight Saving Time. I've added a comment to that effect.
…or, since now it only serves to make the code longer.
|
The Travis failure for this pull request seems spurious: |
|
Yep, Travis CI job deploys mysql-binlog-connector-java build to Sonatype Nexus Snapshots on each push. And only upstream branch gets authenticated. I have submitted an issue #18. In a meantime, please ignore that failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #15
Roadmap to this patch:
BinaryLogClienthas been moved to aAbstractBinaryLogClientsuperclass.AbstractBinaryLogClient, instead of using the listener classes, delegates lifecycle and event handling to abstract methods.BinaryLogClientimplements these abstract methods just like it did originally, and its behavior is therefore unchanged.