Skip to content

Conversation

@MasirJafri1
Copy link
Contributor

@MasirJafri1 MasirJafri1 commented Oct 25, 2024

Related Issue

issue #2030 Solved

Description

issue #2030 Solved

Fixes

1) Solved the active link styling issue in the Home section.

2) Added the same navbar from the Home page to the Career section for consistency.

3) Removed the inconsistent and unorganized page link for ContactUs.html from the Home, Career, and individual pages, replacing it with the well-organized and functional contact.html link.

4) Commented out the repetitive script, which allowed the dark/light mode toggle switch in Home Section to function properly again.

Type of PR

  • Bug fix

Screenshots / videos (if applicable)

Screenshot 2024-10-25 230314

Screenshot 2024-10-25 230341

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

@vercel
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fin-veda ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 5:35pm

@github-actions
Copy link

Thank you for submitting your chaotic pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@deepeshmlgupta deepeshmlgupta merged commit c693f79 into shydev69:main Oct 25, 2024
7 of 9 checks passed
@MasirJafri1
Copy link
Contributor Author

@deepeshmlgupta Can you assign me label of Levels under Gssoc Extd and hacktoberfest too please

@MasirJafri1
Copy link
Contributor Author

@sampadatiwari30 can you assign me labels as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants