Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: Mountains #35

Merged
merged 7 commits into from
Jul 8, 2024
Merged

new resource: Mountains #35

merged 7 commits into from
Jul 8, 2024

Conversation

shyakadavis
Copy link
Owner

@shyakadavis shyakadavis commented Jul 2, 2024

Closes: #32

@shyakadavis shyakadavis self-assigned this Jul 2, 2024
@shyakadavis shyakadavis force-pushed the resource/mountains branch from 3b5b8b0 to 9f2d33e Compare July 3, 2024 20:37
@shyakadavis shyakadavis force-pushed the resource/mountains branch from 9f2d33e to 4c00ebb Compare July 4, 2024 07:49
@shyakadavis
Copy link
Owner Author

IMO, good to go as is, but still debating on how to save the description field.

Would be cool to store the output of a rich-text-editor, i.e. JSON/markdown/html, so I was testing different output formats of some editors.

If I can't make a decision soon, I'll just flag this as tech-debt and just use a pg text type for now.

@shyakadavis shyakadavis marked this pull request as ready for review July 6, 2024 16:45
@shyakadavis
Copy link
Owner Author

Debt - (Improve descriptions of mountains)

@shyakadavis shyakadavis merged commit 463eb04 into main Jul 8, 2024
2 checks passed
@shyakadavis shyakadavis deleted the resource/mountains branch July 8, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mountains
1 participant