Merge pull request #5 from shuebner/tech/update_and_clean

Tech/update and clean
shuebner · Jan 31, 2023 · b325a68 · b325a68
2 parents a55bf2e + 070b0ea
commit b325a68
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 21 deletions.
diff --git a/...eHierarchyDiagnosticSuppressor.Tests/ClosedTypeHierarchyDiagnosticSuppressor.Tests.csproj b/...eHierarchyDiagnosticSuppressor.Tests/ClosedTypeHierarchyDiagnosticSuppressor.Tests.csproj
@@ -8,10 +8,10 @@
  </PropertyGroup>
 
  <ItemGroup>
- <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
+ <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
  <PackageReference Include="NUnit" Version="3.13.3" />
- <PackageReference Include="NUnit3TestAdapter" Version="4.2.1" />
- <PackageReference Include="coverlet.collector" Version="3.1.2">
+ <PackageReference Include="NUnit3TestAdapter" Version="4.3.1" />
+ <PackageReference Include="coverlet.collector" Version="3.2.0">
  <PrivateAssets>all</PrivateAssets>
  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
  </PackageReference>

diff --git a/ClosedTypeHierarchyDiagnosticSuppressor.sln b/ClosedTypeHierarchyDiagnosticSuppressor.sln
@@ -8,9 +8,10 @@ EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{60F51DB5-2BCC-4800-93D2-6B8604FD2DDF}"
  ProjectSection(SolutionItems) = preProject
  .editorconfig = .editorconfig
+ global.json = global.json
  EndProjectSection
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ClosedTypeHierarchyDiagnosticSuppressor.Tests", "ClosedTypeHierarchyDiagnosticSuppressor.Tests\ClosedTypeHierarchyDiagnosticSuppressor.Tests.csproj", "{86A9C76C-96A2-4085-BCDF-C92E2CE4019B}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ClosedTypeHierarchyDiagnosticSuppressor.Tests", "ClosedTypeHierarchyDiagnosticSuppressor.Tests\ClosedTypeHierarchyDiagnosticSuppressor.Tests.csproj", "{86A9C76C-96A2-4085-BCDF-C92E2CE4019B}"
 EndProject
 Global
  GlobalSection(SolutionConfigurationPlatforms) = preSolution

diff --git a/ClosedTypeHierarchyDiagnosticSuppressor/ClosedTypeHierarchyDiagnosticSuppressor.csproj b/ClosedTypeHierarchyDiagnosticSuppressor/ClosedTypeHierarchyDiagnosticSuppressor.csproj
@@ -2,15 +2,15 @@
 
  <PropertyGroup>
  <TargetFramework>netstandard2.0</TargetFramework>
- <IsRoslynComponent>true</IsRoslynComponent>
- <LangVersion>10</LangVersion>
- <Nullable>enable</Nullable>
- 
- <RootNamespace>SvSoft.Analyzers.ClosedTypeHierarchyDiagnosticSuppression</RootNamespace>
- <__CurrentYear>$([System.DateTime]::Now.Year)</__CurrentYear>
- <Copyright>Copyright (C) Sven Hübner 2022 - $(__CurrentYear)</Copyright>
- <Authors>Sven Hübner</Authors>
- <PackageId>SvSoft.Analyzers.ClosedTypeHierarchyDiagnosticSuppression</PackageId>
+ <IsRoslynComponent>true</IsRoslynComponent>
+ <LangVersion>10</LangVersion>
+ <Nullable>enable</Nullable>
+
+ <RootNamespace>SvSoft.Analyzers.ClosedTypeHierarchyDiagnosticSuppression</RootNamespace>
+ <__CurrentYear>$([System.DateTime]::Now.Year)</__CurrentYear>
+ <Copyright>Copyright (C) Sven Hübner 2022 - $(__CurrentYear)</Copyright>
+ <Authors>Sven Hübner</Authors>
+ <PackageId>SvSoft.Analyzers.ClosedTypeHierarchyDiagnosticSuppression</PackageId>
  <PackageTags>discriminated unions, match, switch</PackageTags>
  <PublishRepositoryUrl>true</PublishRepositoryUrl>
  <PackageProjectUrl>https://github.com/shuebner/ClosedTypeHierarchyDiagnosticSuppressor</PackageProjectUrl>
@@ -19,21 +19,21 @@
  </PropertyGroup>
 
  <ItemGroup>
- <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
+ <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
  </ItemGroup>
 
  <ItemGroup>
- <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.11.0" />
- <PackageReference Include="Nullable" Version="1.3.0" PrivateAssets="all" />
+ <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.11.0" PrivateAssets="all" />
+ <PackageReference Include="Nullable" Version="1.3.1" PrivateAssets="all" />
  </ItemGroup>
 
  <PropertyGroup>
- <IncludeBuildOutput>false</IncludeBuildOutput>
- <NoPackageAnalysis>true</NoPackageAnalysis>
+ <IncludeBuildOutput>false</IncludeBuildOutput>
+ <NoPackageAnalysis>true</NoPackageAnalysis>
  </PropertyGroup>
 
  <ItemGroup>
- <None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
+ <None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
  </ItemGroup>
- 
+
 </Project>
diff --git a/ClosedTypeHierarchyDiagnosticSuppressor/TypeHierarchyHelper.cs b/ClosedTypeHierarchyDiagnosticSuppressor/TypeHierarchyHelper.cs
@@ -65,7 +65,9 @@ static bool HasOnlyPrivateConstructorsAndProtectedCopyCtors(INamedTypeSymbol roo
  (IsRecord(rootCandidate) &&
  rootCandidate.Constructors.All(c => c.DeclaredAccessibility == Accessibility.Private || MatchesImplicitlyCreatedRecordCopyCtor(rootCandidate, c)));
 
+#pragma warning disable CS0162 // Unreachable code detected, FP, see https://github.com/dotnet/roslyn/issues/41429
  const string CompilerCreatedCloneMethodNameOnRecordTypes = "<Clone>$";
+#pragma warning restore CS0162 // Unreachable code detected
 
  static bool IsRecord(INamedTypeSymbol recordCandidate) =>
  recordCandidate.MemberNames.Contains(CompilerCreatedCloneMethodNameOnRecordTypes);

diff --git a/global.json b/global.json
@@ -1,5 +1,5 @@
 {
  "sdk": {
- "version": "6.0.300"
+ "version": "6.0.405"
  }
 }