WIP: Improve handling of implicit conjunction. #83
+379
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpgoldman
force-pushed
the
deprecate-implicit-conj
branch
from
0db1110
to
a2fd9c2
Compare
Now issue warnings when it happens, and rewrite. Someday this will be gone...
Changing the treatment of implicit conjunction changed the return from Openstacks plan problem, but still gives valid PDDL plan, so adjusting the comparison.
Previously, it was used both for preconditions and for add and delete lists, which made it a mess. Added `process-add-or-delete` function to handle the latter.
Mostly better comments, and excised some long dead code.
rpgoldman
force-pushed
the
deprecate-implicit-conj
branch
from
d8cfe52
to
366091f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now issue warnings when it happens, and rewrite.
Someday we will remove all the messy parsing.
Marking this as WIP because it shouldn't be merged until there are manual updates.