Fix for allegromodern #160
Draft
+39
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some uses of "NIL" (all caps) which broke compatibility
with Allegro's modern, case-sensitive Lisp, because it wasn't the
default case ("nil").
|
This is going to be more difficult than I had originally thought: even if we support modern mode code, we should really case-flatten the SHOP language constructs like domains and problems, or the tests will be hard to maintain, and we will collide with PDDL practice (PDDL is case-insensitive). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of snippets of code that only work in case-insensitive Lisp. Stumbled on this testing a system that depends on SHOP3 using Allegro modern.