Revise SHOP to use the random-state library for random choices. #131
+65
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpgoldman
force-pushed
the
new-random
branch
8 times, most recently
from
4ceb483
to
a17ff87
Compare
This version uses Shirakumo's (Nicholas Hafner's) random-state library to give repeatable random sequences that are implementation independent.
Fix the loading, which didn't always load RANDOM-STATE soon enough. Add a test for repeatability of random sequences.
There are 4 more theorem-prover tests to check the new random function in SHOP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version uses Shirakumo's (Nicholas Hafner's) random-state library to give repeatable random sequences that are implementation independent.
However it requires use of a patched version of random-state, which is now included in
jenkins/extas a git submodule. I wish this was not necessary.