-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation revisions from Kostas. #100
Conversation
@ko56 -- would you please add a comment that briefly summarizes the changes you've made? It looks like you have revised the treatment of citations, and moved some introductory material above some more obscure material, but it's hard to get an overall picture from groveling over the Texinfo source. So a bullet list of change descriptions would be helpful. |
Almost all my changes w.r.t. the latest in issue 76 are about formatting. |
They were being typeset as if they were text, instead of in a list-like format.
Got it. I am doing a pass over this as a review, and will later make the changes. Going forward, please try to keep your editor from changing whitespace. There are a bunch of blocks in the diff that I have to read carefully to see whether there are textual changes or only that the text has been re-filled. (FWIW, I made this problem worse by committing a version with trailing whitespace removed because of my git configuration...) |
Sorry, I like to have Emacs fill my text, not realizing that it would cause you a problem. |
That's OK; I do, too. I have found it is often helpful to do the re-filling once up front, commit that, and then edit from there. That gives one diff to ignore and one to review. It's not a huge problem, but it makes things easier if we can manage it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to clear these before merging.
Note: should fix the docstring for |
I agree, I didn't mention this issue because I didn't know what to do about it |
Added new issue #101 -- I can work on that in a different PR |
I'm not sure how we can sync up now. How do I get the latest from you? |
I will try to get this all edited together and merged today or tomorrow. Then we can resync, after the merge to |
On the Mac, there is an ancient and incompatible version in `/usr/bin` and I needed the ability to use the one in `/opt/homebrew`. Now the one in your path can be overridden by setting an environment variable.
I will merge this after tests run. Need to update the online documentation pages, too. |
I obtained all your changes by
And one last thing: did you see my proposal in "Add alternative syntax for methods #72"? |
Needs review followed by merge to master.