Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maptainer Mapcut 2024 #3840

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

meemofcourse
Copy link
Contributor

@meemofcourse meemofcourse commented Nov 26, 2024

About The Pull Request

This pull request removes the following ships from the code:

  • independent_beluga
    • The concept is cool, and the effort placed into the ship is commendable, but it does not work in practice
  • independent_box
    • This ship is old, with a lack of factional play and any other gimmick than healing. A new indie medical ship is in the works already
  • independent_lagoon
    • This is an old, very large BarRP ship. It is already adminspawn, might as well finish the job
  • independent_schmiedeberg
    • The Schmie is old and specializes in a very shallow mechanic
  • independent_tranquility
    • This ship is explicitly excluded from the main gameplay loop and is reliant exclusively on your ability to roleplay with your own crewmates instead of the outside world. In other words, BarRP. This is also possibly the oldest ship in this list
  • inteq_hound
    • The Hound is old, aspawn, nobody uses it, and is already replaced
  • nanotrasen_gecko
    • The Gecko has some awful pipe layouts, with purposeless maints. It is also incredibly old
  • nanotrasen_heron (and by extension nanotrasen_falcon)
    • This ship is not used, works on old Nanotrasen lore standards, and it is also way too fucking big with a meh layout
  • nanotrasen_mimir
    • This map's concept is badly executed, and it is not used
  • pirate_noderider (Jupiter)
    • SEC is in lore hell, the concept is good but can be executed better. Nobody uses this
  • solgov_chronicle
    • This ship suffers from a particularly bad case of Bridge Isolation, and was a testbed for the other SolGov ships. Could do with a replacement

This pull request removes the following ruins from the code:

  • beach_fishing_hut
    • Might as well just start over
  • beach_float_resort
    • This is a gigantic map with nothing in it
  • beach_ocean_town
    • This is a gigantic map with nothing in it
  • icemoon_hydroponics_lab
    • jesus christ
  • jungle_abandoned_library
    • The ruin's concept is alright, but it is executed poorly and does not entice its loot properly (people avoid it because it sucks to fight in for not too worth it)
  • rockplanet_nomadcrash
  • rockplanet_harmfactory
  • whitesands_surface_medipen_plant
    • This ruin is not fun
  • astraeus
    • Holy shit this is old
  • corporate_mining
  • wasteplanet_lab
    • if you tell me this is a good ruin i will kill you

This also renames the ruins.dm file into _ruins.dm and moves it into the datum/ruins folder.


Faction
Ships
Indie 10
Syndicate
7
Nanotrasen 4
Inteq
4
PGF 3
Pirates
2
SolCon 2
CLIP
1
Roumain 1
Planet
Ruins
Jungle
6
Lava
6
Space 5
Waste 5
Rock
5
Sand
5
Beach 4
Ice
4

Why It's Good For The Game

Thank you, Mapper, for so kindly and skillfully granting us the fruits of your labor. But now I'm afraid you've outlived your usefulness. You know just enough to be a threat to me, and, with that, the future of the Shiptest Technical Test. I will not say Fasidomi misol, Mapper... as I can assure you, we will Never. Meet. Again.

For real, though. A lot of these ships had it coming.

Changelog

🆑
del: Beluga-class, Box-class, Lagoon-class, Schmiedeberg-class, Tranquility-class
del: Hound-class
del: Gecko-class, Heron-class (also Falcon-class), Mimir-class
del: Jupiter-class
del: Chronicle-class
del: Many ruins, mostly for being old, have been removed
/:cl:

@meemofcourse meemofcourse requested a review from a team as a code owner November 26, 2024 19:13
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. DME Edit Ship Ship successfully tested. Code change Watch something violently break. Ruin Ruin successfully tested. labels Nov 26, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Nov 27, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Merge Conflict Use Git Hooks, you're welcome. Ruin Ruin successfully tested. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant