Factions Housekeeping #3815
Open
Factions Housekeeping #3815
+226
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MarkSuckerberg
force-pushed
the
faction-tidy
branch
from
7fa1930
to
0785c12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Tidies up a little bit of our faction implementation, removing some unnecessary vars and simplifying others, and finally makes ship prefixes immutable, as well as checks if ships have the proper prefix for their faction. Also adds a lint for SolGov/Con capitalization, and adds a ton more information to the autowiki ship boxes for use.
Why It's Good For The Game
Stops people from changing ships to be factions they aren't without admin intervention.
Changelog
🆑
tweak: Ship Prefixes are now immutable.
/:cl: