Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated R language syntax #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kylebutts
Copy link

There is now a new preferred language syntax for the R language (posit-dev/positron#5017). Given this produces better quality highlighting and is much more highly maintained than the previous one, I suggest changing to this one.

E.g. before, function calls were inconsistently highlighted:
Before:
image
After:
image

Before:
image
After:
image

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for textmate-grammars-themes failed.

Name Link
🔨 Latest commit 76a51ef
🔍 Latest deploy log https://app.netlify.com/sites/textmate-grammars-themes/deploys/67c78ac44578860008652564

@antfu
Copy link
Member

antfu commented Mar 5, 2025

I am concerned about the license, I think it's a bit tricky as it's no longer a no-brainer to bundle and redistribute

@kylebutts
Copy link
Author

@lionel- I'm wondering if there's a way to use the updated syntax. Shiki uses vscode grammars to produce high-quality code highlighting for html output. Perhaps, we could move the updated syntax .json back to the vscode-R repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants