Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リトライ処理の改善 #192

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Hexa
Copy link
Contributor

@Hexa Hexa commented Nov 26, 2024

This pull request includes several changes to improve error handling, retry mechanisms, and data handling in the speech processing server. The most important changes are grouped by their themes: error handling improvements, retry mechanism enhancements, and data handling adjustments.

Error Handling Improvements:

  • Simplified error handling by joining errors using errors.Join and ensuring proper error propagation in amazon_transcribe_handler.go and speech_to_text_handler.go. [1] [2]
  • Added detailed logging for errors and ensured error messages are sent to clients in handler.go. [1] [2]

Retry Mechanism Enhancements:

  • Reset the retry count upon successful request handling in amazon_transcribe_handler.go and speech_to_text_handler.go. [1] [2]
  • Introduced a mechanism to cancel only specific parts of the process during retries, and ensured continuous packet reception to detect disconnections in handler.go. [1] [2]

Data Handling Adjustments:

  • Refactored the readPacketWithHeader function to simplify its usage and removed unnecessary error handling in handler.go and handler_test.go. [1] [2] [3]
  • Modified the opus2ogg function to handle data packets more efficiently using channels in handler.go.

These changes collectively enhance the robustness and reliability of the speech processing server by improving error handling, optimizing retry mechanisms, and refining data handling processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant