Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats Webhook の統計情報に対応する #41

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

tnamao
Copy link
Collaborator

@tnamao tnamao commented Jun 5, 2024

変更履歴

  • [ADD] Sora の Stats Webhook の統計情報に対応する
    • sora_stats_webhook_total メトリクスを追加し、ラベルに successful failed を設ける
    • @tnamao

This pull request primarily focuses on enhancing the Sora Stats Webhook's statistical information. The changes include the addition of totalStatsWebhook to the WebhookMetrics struct, updates to the soraWebhookReport struct, and modifications to various test files to accommodate the new stats webhook metrics.

Additions to the Webhook Metrics and Sora Webhook Report:

  • collector/sora_api.go: Added TotalSuccessfulStatsWebhook and TotalFailedStatsWebhook to the soraWebhookReport struct. This allows the collection of successful and failed stats webhook data.
  • collector/webhook.go: Added totalStatsWebhook to the WebhookMetrics struct and the Describe method. This enables the description of the total number of stats webhooks. [1] [2]
  • collector/webhook.go: Updated the Collect method to include counters for successful and failed stats webhooks. This ensures that these metrics are collected.

Updates to Test Files:

  • main_test.go: Added total_failed_stats_webhook and total_successful_stats_webhook to the test data in various places. This ensures that the new stats webhook metrics are included in the tests. [1] [2] [3] [4]
  • Various metrics test files: Added entries for sora_stats_webhook_total for both successful and failed states. This ensures that the new stats webhook metrics are included in the metrics tests. [1] [2] [3] [4] [5] [6]

Documentation Update:

  • CHANGES.md: Documented the addition of the Sora Stats Webhook statistics.

@tnamao
Copy link
Collaborator Author

tnamao commented Jun 5, 2024

マージします

@tnamao tnamao merged commit 57ac760 into develop Jun 5, 2024
2 checks passed
@tnamao tnamao deleted the feature/stats-webhook branch June 5, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant