Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更履歴
sora_stats_webhook_total
メトリクスを追加し、ラベルにsuccessful
failed
を設けるThis pull request primarily focuses on enhancing the Sora Stats Webhook's statistical information. The changes include the addition of
totalStatsWebhook
to theWebhookMetrics
struct, updates to thesoraWebhookReport
struct, and modifications to various test files to accommodate the new stats webhook metrics.Additions to the Webhook Metrics and Sora Webhook Report:
collector/sora_api.go
: AddedTotalSuccessfulStatsWebhook
andTotalFailedStatsWebhook
to thesoraWebhookReport
struct. This allows the collection of successful and failed stats webhook data.collector/webhook.go
: AddedtotalStatsWebhook
to theWebhookMetrics
struct and theDescribe
method. This enables the description of the total number of stats webhooks. [1] [2]collector/webhook.go
: Updated theCollect
method to include counters for successful and failed stats webhooks. This ensures that these metrics are collected.Updates to Test Files:
main_test.go
: Addedtotal_failed_stats_webhook
andtotal_successful_stats_webhook
to the test data in various places. This ensures that the new stats webhook metrics are included in the tests. [1] [2] [3] [4]sora_stats_webhook_total
for both successful and failed states. This ensures that the new stats webhook metrics are included in the metrics tests. [1] [2] [3] [4] [5] [6]Documentation Update:
CHANGES.md
: Documented the addition of the Sora Stats Webhook statistics.