Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data_channels 項目に header 項目を追加しました。
dc.header は string から json にパースして設定しています。
This pull request introduces a new
Header
property to theDataChannel
class and updates related files to support this addition. The most important changes include updates to theSora.Config
,DataChannel
class, and associated methods in both C# and C++ code, as well as the protocol buffer definition.Enhancements to
DataChannel
:Sora/Sora.cs
: AddedHeader
property to theDataChannel
class.Sora/Sora.cs
: UpdatedConnect
method to set theHeader
property if it is not null.Protocol buffer updates:
proto/sora_conf_internal.proto
: Addedheader
field to theDataChannel
message.C++ code updates:
src/sora.cpp
: UpdatedDoConnect
method to parse and set theHeader
property from JSON.Documentation updates:
CHANGES.md
: Documented the addition of theHeader
property toDataChannels
.