Skip to content

added social-share-button gem #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

probinson2015
Copy link
Contributor

Added social share gem so that individual resources can be shared accordingly. For this update, the share buttons that are enabled are "twitter facebook google_plus google_bookmark tumblr".

@natsteinmetz
Copy link
Member

Two comments:

  1. The gem version 0.1.9 is not available anymore, so this throws an error when attempting bundle install. I have used the latest version instead, 0.2.1, and that one works.
  2. Can you add LinkedIn and Email to share from? And I would remove the Google Bookmark option - 2 Google share options are a bit confusing. I would also remove Tumblr, and just keep the 'main' ones: Twitter, Facebook, LinkedIn, Google+ and Email. And potentially Pinterest, once the bug you mentioned on Trello is fixed. Considering we're using a new version of the gem here, maybe the Pinterest integration works now?

@natsteinmetz
Copy link
Member

natsteinmetz commented Apr 15, 2017

Hey @probinson2015 , did you still want to look at those comments I made and update this branch? It would be nice to get those buttons in :) Otherwise I can take care of doing those updates as well. Just let me know? Thanks!

@natsteinmetz natsteinmetz self-requested a review July 4, 2018 07:16
@natsteinmetz natsteinmetz self-assigned this Jul 4, 2018
@probinson2015
Copy link
Contributor Author

Hi @natsteinmetz this has been updated. Pinterest still requires a thumbnail in order to share on their site. Would you like to use one of our She's Coding thumbnails, maybe space cat? The only problem I can think of is the gem doesn't currently allow of a way to provide a special url parameter that is only to be used for a specific button. Could probably figure out a way to make it work though with a little jQuery but would still need to know which image to use. This is an issue only for Pinterest sharing. Thanks!

@natsteinmetz
Copy link
Member

@probinson2015 Thanks for the ping! 😃This looks good and works as expected - I was wondering though: could you make the icons a tidbit bigger, and spread them out a bit? There's enough space on their right side to give them a bit of breathing room.

Let me know if you'd prefer this to be opened as separate issue, that'd be no problem.

natsteinmetz
natsteinmetz previously approved these changes Jan 14, 2019
Copy link
Member

@natsteinmetz natsteinmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it for now, but let me know if you want to change the size of and margin around the icons in this PR. Thanks! 😄

@probinson2015
Copy link
Contributor Author

probinson2015 commented Jan 16, 2019

image
Hi Nathalie, I've updated this per your request. I thought any more spread out and it's a bit jarring to the eye as it's quite a colorful pattern and it's repeated on every tile. Let me know what you think. I can update accordingly. Thank you!

@probinson2015
Copy link
Contributor Author

@natsteinmetz updated. :)

@shescoding shescoding deleted a comment from probinson2015 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants