-
Notifications
You must be signed in to change notification settings - Fork 35
added social-share-button gem #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Two comments:
|
Hey @probinson2015 , did you still want to look at those comments I made and update this branch? It would be nice to get those buttons in :) Otherwise I can take care of doing those updates as well. Just let me know? Thanks! |
Hi @natsteinmetz this has been updated. Pinterest still requires a thumbnail in order to share on their site. Would you like to use one of our She's Coding thumbnails, maybe space cat? The only problem I can think of is the gem doesn't currently allow of a way to provide a special url parameter that is only to be used for a specific button. Could probably figure out a way to make it work though with a little jQuery but would still need to know which image to use. This is an issue only for Pinterest sharing. Thanks! |
@probinson2015 Thanks for the ping! 😃This looks good and works as expected - I was wondering though: could you make the icons a tidbit bigger, and spread them out a bit? There's enough space on their right side to give them a bit of breathing room. Let me know if you'd prefer this to be opened as separate issue, that'd be no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve it for now, but let me know if you want to change the size of and margin around the icons in this PR. Thanks! 😄
@natsteinmetz updated. :) |
Added social share gem so that individual resources can be shared accordingly. For this update, the share buttons that are enabled are "twitter facebook google_plus google_bookmark tumblr".