Skip to content

adding newsletter form issue #142 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lau626
Copy link

@lau626 lau626 commented Oct 26, 2018

No description provided.

@cherchezlafemme
Copy link
Member

@natsteinmetz can you take a look at this PR? I don't have context regarding the mailchimp subscription situation.

Copy link
Member

@natsteinmetz natsteinmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lau626 Apologies for the super late reaction. Yes, we do already have a mailchimp account, you can use 'https://shescoding.us13.list-manage.com/subscribe/post?u=2c06e9aeddb5548a94e22590c&id=f7dc178a8f' - thanks.

Regarding the fields, email only is fine. But could you make sure to use the same font size and colors as for the rest of the page. It seems that you use the correct font, but 'Subscribe to Our Email List' should be a header like 'Purpose' for example. And the button should be green like the other buttons on the page.

Also, considering we only have the one field, I would remove the * next to the field, and the * explanation saying 'indicates required'.

Thanks, and please let us know if we can help or in case you won't be able to work on it anymore, considering it took us so long to respond. Again, apologies for that. Thanks! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants