Set schema for manifest #2099
Merged
Set schema for manifest #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdushantha
requested changes
May 6, 2024
sdushantha
requested changes
May 6, 2024
|
ln980 was added in cc95d4e and ln2268 in 1b14b88, both of #2068. The errorMsg str lists of those two items are somewhat vague and don't always have an impact, and it's possible that someone would remove one thinking that it's no longer needed. Sorta like how YouTube gave us completely different results depending on region --- something that not everyone would pick up on in a quick test |
|
huh. now that you mention it, those two lines are not compliant with the schema... time to update |
|
Updated so that mixed error values are flagged. i.e. Leaving an errorCode present while errorType is set to message would be yellow-lined. |
sdushantha
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing major here.
Sets the schema for data[.]json to allow for autocomplete, validation, etc. Reduces the likelihood of things being missed or left behind.
Setting the schema happened to uncover a couple minor instances of this (old username_unclaimed, noPeriod, etc). Those have been cleared.
I may adapt this in the future to disallow keys such as errorMsg when they don't match their dependent errorTypes, but that's a later problem.Done.Looks like this was also mentioned back in #1336 and #1338. (so, closes #1336, closes #1338, if merged)