Separate modal overlay opening element option #1837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1836
modalOverlayOpeningElement
option for specifying anHTMLElement
or string selector for what the modal should targetgetOpeningProperties
method to modal so I could confirm the dimensions matched up with the desired element. Let me know if you'd rather this test be written in a different way that didn't require changing the API of modal.general
to reuse aparseElementOrSelector
function for the new option andattachTo.element
parseElementOrSelector
function