Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug fix in example for #236 and more. #265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nao1215
Copy link

@nao1215 nao1215 commented Apr 28, 2022

This PR is a modification for the sample code, not to the ShellSpec itself.
I fixed two bugs that are like typo. One of the modification is to Issue #236.
The other was marked and commented as a bug in the code.

After the modification, the test results are as follows.

  • Before
$ pwd
/home/nao/Desktop/shellspec/contrib/demo
$ shellspec 
Running: /bin/sh [sh]
.F

Examples:
  1) example add() function performs addition
     When call add 2 3

     1.1) The output should eq 5

            expected: 5
                 got: 6

          # spec/demo_spec.sh:14

Finished in 0.07 seconds (user 0.04 seconds, sys 0.00 seconds)
2 examples, 1 failure


Failure examples / Errors: (Listed here affect your suite's status)

shellspec spec/demo_spec.sh:12 # 1) example add() function performs addition FAILED
  • After
$ shellspec 
Running: /bin/sh [sh]
..

Finished in 0.03 seconds (user 0.02 seconds, sys 0.01 seconds)
2 examples, 0 failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant