feat: Dropdown 组件新增 shape: 同 Button 组件的shape
#925
+23
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saint3347
changed the title
Dropdown 组件新增 buttonShape: 同 Button 组件的shapeDropdown 组件新增 shape: 同 Button 组件的shape
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- package.json: Language not supported
- docs/api/shineout/dropdown.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
packages/shineout/src/dropdown/example/t-002-no-placeholder.tsx:45
- The property name
buttonShapeshould be consistent with theshapeproperty used in the code.
<Dropdown data={data} placeholder={moreIcon} buttonShape="circle" hideArrow />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Background
Changelog
Dropdown组件新增buttonShape: 同Button组件的shapePlayground id
Other information