Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loaders: Enhance ContractResult.loaderResult type #128

Merged
merged 5 commits into from
Sep 25, 2024
Merged

loaders: Enhance ContractResult.loaderResult type #128

merged 5 commits into from
Sep 25, 2024

Conversation

yohamta
Copy link
Contributor

@yohamta yohamta commented Sep 25, 2024 •
edited
Loading

Follow-up PR to #127

Change overview

  • Introduced EtherscanContractResult type
  • Introduced SourcifyContractMetadata type
  • Updated ContractResult.loaderResult type

shazow
shazow approved these changes Sep 25, 2024
View reviewed changes
Copy link
Owner

@shazow shazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor suggestions.

src/loaders.ts Outdated Show resolved Hide resolved
src/loaders.ts Outdated Show resolved Hide resolved
yohamta and others added 2 commits September 26, 2024 00:44
@yohamta @shazow
Update src/loaders.ts
02c212a 
Co-authored-by: Andrey Petrov <[email protected]>
@yohamta @shazow
Update src/loaders.ts
478d838 
Co-authored-by: Andrey Petrov <[email protected]>
@shazow shazow merged commit 1055953 into shazow:main Sep 25, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazow shazow shazow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yohamta @shazow