Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make .debdiff imply .diff using syntax_mapping toml #2947

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make .debdiff imply .diff using syntax_mapping toml #2947

wants to merge 3 commits into from

Conversation

jacg
Copy link

@jacg jacg commented Apr 26, 2024

Closes #2940

I would still like some guidance on what tests need to be added.

@jacg jacg mentioned this pull request May 13, 2024
Open
@cyqsimon
Copy link
Contributor

cyqsimon commented May 15, 2024 •
edited

If it's a Debian-specific extension, it should go into /src/syntax_mapping/builtins/linux/ rather than unix-family/ no?

On second thought, I think maybe it's better to put it in common/. There is no reason to not highlight .debdiff as .diff on Windows.

@cyqsimon
Copy link
Contributor

And I don't think we need tests for trivial additions like these. The build will fail if the TOML file is bad.

@jacg jacg marked this pull request as ready for review May 15, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-hall keith-hall keith-hall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please support .debdiff files
3 participants
@jacg @cyqsimon @keith-hall