Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Ruby 3.3 #480

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented May 19, 2024

Ruby 3.3 is the latest stable version of Ruby

Summary by CodeRabbit

  • Chores
    • Updated CI workflows to support Ruby version 3.3, ensuring compatibility with the latest Ruby features and improvements.

Copy link

coderabbitai bot commented May 19, 2024

Warning

Rate Limit Exceeded

@tagliala has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 46 minutes and 4 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 4be0c6b and 1c7b174.

Walkthrough

The recent updates involve expanding the Ruby version support in the GitHub workflows. Both generator.yml and ruby.yml files have been modified to include Ruby 3.3 in their testing matrices. This ensures that the project is tested against the latest Ruby version, enhancing compatibility and reliability.

Changes

File Path Change Summary
.github/workflows/generator.yml Updated supported Ruby versions to include 3.3 and added a new matrix entry for Ruby 3.3 with Gemfile-rails.6.0.x.
.github/workflows/ruby.yml Changed Ruby version in job setup from 3.2 to 3.3 and expanded matrix to include Ruby 3.3 with a specific Gemfile.

In our code garden, Ruby blooms anew,
From 2.7 to 3.3, our tests now grew.
With workflows updated, we strive for the best,
Ensuring our gem passes every test.
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 779d0c7 and 4be0c6b.
Files selected for processing (2)
  • .github/workflows/generator.yml (2 hunks)
  • .github/workflows/ruby.yml (3 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/generator.yml
Additional comments not posted (3)
.github/workflows/ruby.yml (3)

24-24: Update to Ruby 3.3 in the lint job looks good.


36-36: Addition of Ruby 3.3 to the test matrix is appropriate.


50-51: Exclusion of Ruby 3.3 with Gemfile-rails.6.0.x is correctly set.

Ruby 3.3 is the latest stable version of Ruby
@tagliala tagliala force-pushed the chore/test-against-ruby-33 branch from 4be0c6b to 1c7b174 Compare May 19, 2024 10:10
@justin808 justin808 merged commit 0d1de8e into shakacode:main May 20, 2024
39 checks passed
@justin808
Copy link
Member

Thanks @tagliala

@tagliala tagliala deleted the chore/test-against-ruby-33 branch May 20, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants