Pin pnpm Docker example and document protobufjs omission#3440
Draft
justin808 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3437.
Pins the Docker deployment pnpm example to the exact packageManager version and documents why protobufjs is intentionally omitted from pnpm.onlyBuiltDependencies.
This preserves reproducible docs while clarifying ignored build script output for future dependency updates.
Pull Request checklist
Add/update test to cover these changesUpdate CHANGELOG fileOther Information
Validated with
corepack pnpm install --frozen-lockfile,corepack pnpm exec prettier --check docs/oss/deployment/docker-deployment.md package.json, andgit diff --check.Note
Low Risk
Documentation and comment-only changes with no runtime, auth, or dependency behavior changes.
Overview
Aligns the Docker deployment pnpm example with the repo’s pinned
packageManagerversion (10.33.4) instead of a loose major-only pin, so container builds match local/CI installs.Documents in
package.jsonwhyprotobufjsstays offpnpm.onlyBuiltDependencies: its postinstall is informational (version-scheme warnings), not a trusted native build step—reducing confusion when pnpm reports ignored lifecycle scripts.Reviewed by Cursor Bugbot for commit aec7e76. Bugbot is set up for automated code reviews on this repo. Configure here.