Switch to bundler 2.5.9 and commit top gemfile.lock #1619
Conversation
WalkthroughThe updates revolve around upgrading the Bundler version from 2.5.3 to 2.5.9 across various configuration and workflow files, ensuring compatibility and potential enhancements. The specific Bundler version constraint has been removed from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
justin808
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
spec/dummy/Gemfile.lockis excluded by!**/*.lock
Files selected for processing (7)
- .circleci/config.yml (1 hunks)
- .github/workflows/examples.yml (2 hunks)
- .github/workflows/lint-js-and-ruby.yml (2 hunks)
- .github/workflows/main.yml (4 hunks)
- .github/workflows/rspec-package-specs.yml (2 hunks)
- .travis.yml (1 hunks)
- Gemfile.development_dependencies (1 hunks)
Files skipped from review due to trivial changes (7)
- .circleci/config.yml
- .github/workflows/examples.yml
- .github/workflows/lint-js-and-ruby.yml
- .github/workflows/main.yml
- .github/workflows/rspec-package-specs.yml
- .travis.yml
- Gemfile.development_dependencies
| @@ -9,7 +9,6 @@ gem "sass-rails", "~> 6.0" | |||
| gem "uglifier" | |||
| gem "jquery-rails" | |||
| gem "puma", "~> 6.0" | |||
| gem "bundler", "2.5.3" | |||
There was a problem hiding this comment.
@Judahmeek any need for this?
| @@ -3,7 +3,7 @@ sudo: required | |||
| language: ruby | |||
|
|
|||
| rvm: | |||
| - 2.5.3 | |||
There was a problem hiding this comment.
@Judahmeek I don't think the .travis file is used any more.
There was a problem hiding this comment.
Neither Travis or CircleCI are used anymore. Would you like us to remove those files?
There was a problem hiding this comment.
Circle CI might be a good example to keep. I'd say that we could move the files to an /archive directory with a README? Or maybe one can find in the git history if we document that this in a section on CI for ROR?
|
@Judahmeek if this works, I'll merge. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Gemfile.lockis excluded by!**/*.lock
Files selected for processing (1)
- .gitignore (1 hunks)
Files skipped from review due to trivial changes (1)
- .gitignore
Summary
2.5.3 lock of bundler causes these errors for me:
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
/Users/justin/.asdf/installs/ruby/3.2.2/bin/ruby extconf.rb
checking for unistd.h... yes
checking for linux/aio_abi.h... no
checking for linux/io_uring.h... no
checking for sys/select.h... yes
checking for port_event_t in poll.h... no
checking for sys/epoll.h... no
checking for sys/event.h... yes
checking for sys/queue.h... yes
checking for port_event_t in port.h... no
checking for sys/resource.h... yes
creating Makefile
current directory: /Users/justin/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/nio4r-2.5.8/ext/nio4r
make DESTDIR= sitearchdir=./.gem.20240515-35487-luo5ud sitelibdir=./.gem.20240515-35487-luo5ud clean
This change is
Summary by CodeRabbit