Follow-up to #1606 #1611
Merged
Follow-up to #1606 #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
requested changes
Apr 15, 2024
| @@ -99,7 +99,7 @@ def add_yarn_dependencies | |||
| css_minimizer_webpack_plugin_version = node_major_version >= 18 ? "" : "@<6.0.0" | |||
| css_minimizer_webpack_plugin = "css-minimizer-webpack-plugin#{css_minimizer_webpack_plugin_version}" | |||
|
|
|||
| run "yarn add 'css-loader@<7.0.0' '#{css_minimizer_webpack_plugin}' mini-css-extract-plugin style-loader" | |||
| run "yarn add 'css-loader@<7.0.0' '#{css_minimizer_webpack_plugin}' mini-css-extract-plugin 'style-loader@<4.0.0'" # rubocop:disable Layout/LineLength | |||
There was a problem hiding this comment.
I don't see why we're locking this:
https://github.com/webpack-contrib/style-loader/releases
New projects can update or change the dependency if needed.
|
@Judahmeek let's just update the node version for the tests. If new generated projects need a newer node version or older style-loader, that's fine. |
Judahmeek
force-pushed
the
judahmeek/1606-follow-up
branch
from
e85670e
to
0f49f8d
Compare
Judahmeek
force-pushed
the
judahmeek/1606-follow-up
branch
from
0f49f8d
to
e20c6eb
Compare
justin808
reviewed
Apr 22, 2024
react_on_rails.gemspec
Outdated
| @@ -29,6 +29,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency "addressable" | |||
| s.add_dependency "connection_pool" | |||
| s.add_dependency "execjs", "~> 2.5" | |||
| s.add_dependency "sqlite3", "~> 1.6" | |||
There was a problem hiding this comment.
why make this a dependency? it is needed for tests only?
There was a problem hiding this comment.
Correct. My mistake.
justin808
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds lock files for the changes made in #1606 & also restricts the version of
style-loaderin rspec examples (style-loaderv4 requires a higher version of node than we are currently using) so that CI will pass.This change is