Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Implementation of RSC #1573

Closed
wants to merge 1 commit into from
Closed

Initial Implementation of RSC #1573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"eslint-plugin-jsx-a11y": "^6.7.1",
"eslint-plugin-prettier": "^3.4.1",
"eslint-plugin-react": "^7.32.1",
"husky": "^4.3.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

husky and yalc should be separate PRs.

"jest": "^28.1.3",
"jest-environment-jsdom": "^28.1.3",
"jsdom": "^16.4.0",
Expand All @@ -44,7 +45,8 @@
"react-transform-hmr": "^1.0.4",
"redux": "^4.2.0",
"ts-jest": "^28.0.8",
"typescript": "^4.9.4"
"typescript": "^4.9.4",
"yalc": "^1.0.0-pre.27"
},
"dependencies": {
"@babel/runtime-corejs3": "^7.12.5"
Expand All @@ -54,6 +56,10 @@
"react": ">= 16",
"react-dom": ">= 16"
},
"exports": {
".": "./node_package/lib/ReactOnRails.js",
"./*": "./node_package/lib/*.js"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhaledEmaraDev can you explain this?

Seems odd to start exporting everything from package.json

Why not add what's necessary to the current exports?

We already have:
https://github.com/shakacode/react_on_rails/blob/master/node_package/src/ReactOnRails.ts#L292-L293

"files": [
"node_package/lib",
"webpackConfigLoader.js"
Expand Down Expand Up @@ -92,5 +98,10 @@
"bugs": {
"url": "https://github.com/shakacode/react_on_rails/issues"
},
"homepage": "https://github.com/shakacode/react_on_rails#readme"
"homepage": "https://github.com/shakacode/react_on_rails#readme",
"husky": {
"hooks": {
"pre-commit": "yalc check"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed pre-commit?

}
}
}
Loading
Loading