Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruby 3 and node 16 & 18 in CI #1568

Merged
merged 16 commits into from
Aug 26, 2023
Merged

Add ruby 3 and node 16 & 18 in CI #1568

merged 16 commits into from
Aug 26, 2023

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented Jul 27, 2023 •
edited by justin808
Loading

Summary

Update Ruby and Node versions in CI

Other Information

Closes #1565

This change is Reviewable

@justin808
Copy link
Member

Not passing CI

@ahangarha ahangarha marked this pull request as draft July 31, 2023 12:17
@Judahmeek Judahmeek marked this pull request as ready for review August 22, 2023 15:26
ahangarha
ahangarha commented Aug 22, 2023
View reviewed changes
lib/react_on_rails/git_utils.rb
Copy link
Contributor Author

@ahangarha ahangarha Aug 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I don't have any proposal for fixing the issue, this solution seems a bit hacky. It fixes our failing tests but it doesn't make sense to me. We can pass git_installed = false while we execute git status ....

Update:
I think there is another issue as well. We set git_installed to $CHILD_STATUS.success? before we run git status --porcelain. This means we do not capture suscess of the git command execution.

Maybe we should extract the entire git logic out of this function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a form of mocking the git status for testing, because without it, we get a Cannot proxy frozen objects, rspec-mocks relies on proxies for method stubbing and expectations. error.

@justin808 justin808 merged commit 952e05b into master Aug 26, 2023
26 checks passed
@justin808 justin808 deleted the update-ruby-and-node-in-ci branch August 26, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Judahmeek Judahmeek Judahmeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include Ruby 3 and node 18 to CI workflows
3 participants
@ahangarha @justin808 @Judahmeek