Consolidate main dependency updates#18
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 13 minutes.Comment |
Greptile SummaryThis PR consolidates multiple Dependabot dependency updates (Rails 8.1.3, Puma 8.0.1, Brakeman 8.0.4, Solid Queue 1.4.0, and others), adds Ruby/Node version files for CI, threads pnpm/Node setup into the test and system-test CI jobs, and fixes Puma 8's IPv6-first bind change by explicitly defaulting to Confidence Score: 4/5Safe to merge; only a P2 style finding around the removed --ensure-latest Brakeman flag. All changes are straightforward dependency bumps, CI plumbing, and a well-justified Puma bind-host fix. The single finding is a P2 (removal of --ensure-latest from Brakeman), which does not block merging but is worth addressing. bin/brakeman — removal of --ensure-latest slightly weakens the security scanner version gate Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[CI Trigger: push/PR] --> B{Job}
B --> C[scan_ruby]
B --> D[lint]
B --> E[test]
B --> F[system-test]
C --> C1[Checkout]
C1 --> C2[Setup Ruby]
C2 --> C3[bin/brakeman --no-pager]
C3 --> C4[bin/bundler-audit]
D --> D1[Checkout]
D1 --> D2[Setup Ruby]
D2 --> D3[RuboCop cache]
D3 --> D4[bin/rubocop]
E --> E1[Install apt packages]
E1 --> E2[Checkout]
E2 --> E3[Setup pnpm + Node NEW]
E3 --> E4[pnpm install --frozen-lockfile NEW]
E4 --> E5[Setup Ruby]
E5 --> E6[bin/rails db:test:prepare test]
F --> F1[Install apt packages]
F1 --> F2[Checkout]
F2 --> F3[Setup pnpm + Node NEW]
F3 --> F4[pnpm install --frozen-lockfile NEW]
F4 --> F5[Setup Ruby]
F5 --> F6[bin/rails db:test:prepare test:system]
F6 --> F7{failure?}
F7 -->|yes| F8[upload-artifact screenshots]
Reviews (1): Last reviewed commit: "Consolidate main dependency updates" | Re-trigger Greptile |
| @@ -2,6 +2,4 @@ | |||
| require "rubygems" | |||
| require "bundler/setup" | |||
|
|
|||
There was a problem hiding this comment.
The --ensure-latest flag caused Brakeman to exit non-zero if it wasn't the most current release, which enforced keeping the scanner up-to-date as a CI gate. Removing it means future CI runs will silently pass even if a newer Brakeman version with additional checks is available. Since Brakeman was just bumped to 8.0.4 in this same PR the flag would pass today, so it might be worth re-adding now that the version is current.
Summary
main, including Bootsnap1.24.1, Puma8.0.1, Rails8.1.3, Brakeman8.0.4, Propshaft1.3.2, Selenium WebDriver4.43.0, Solid Queue1.4.0, Thruster0.1.20, Web Console4.3.0, and related indirect updatesruby/setup-rubycan resolve the CI Ruby version on Dependabot and regular PRs0.0.0.0by default, withPUMA_BIND_HOSTavailable as an override, to preserve Docker/Kamal/Thruster connectivity after Puma's IPv6 default-bind change9.5.0; Shakapacker 10 still needs a coordinated gem and npm package upgradeValidation
Supersedes
Note
Medium Risk
Moderate risk due to core framework/server and security-tool dependency upgrades and a Puma bind default change that could affect connectivity in some environments. CI/test changes may also surface new failures if Node/pnpm or asset generation assumptions differ across runners.
Overview
Consolidates a batch of dependency upgrades (notably Rails
8.1.3, Puma8.0.1, Bootsnap1.24.1, Brakeman8.0.4, Solid Queue1.4.0, Selenium4.43.0, plus indirect updates) and adjustsbin/brakemanto stop forcing--ensure-latest.CI is updated to pin toolchain versions via new
.ruby-version/.tool-versions, install Node/pnpm dependencies before running Rails tests/system tests, and bump GitHub Actions used for caching/artifact upload.Runtime/test behavior changes include binding Puma to
0.0.0.0by default (configurable viaPUMA_BIND_HOST), adding a committeddb/schema.rb, and ensuring tests generate React-on-Rails packs before compiling assets intest/test_helper.rb.Reviewed by Cursor Bugbot for commit 48d9a6b. Bugbot is set up for automated code reviews on this repo. Configure here.