-
Notifications
You must be signed in to change notification settings - Fork 1
docs: add badges to README #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add status badges similar to react_on_rails and shakapacker: - MIT license badge - Gem version badge from badge.fury.io - Ruby CI workflow badge from GitHub Actions These badges provide quick visibility into the project's status and make the README more professional and consistent with other ShakaCode projects. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
WalkthroughAdded three badges (License, Gem Version, Ruby workflow) to the top of README.md. These badges provide visual status indicators for the project without modifying any functional content or documentation structure. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: test (macos-latest, head)
- GitHub Check: test (ubuntu-latest, 3.1)
- GitHub Check: test (ubuntu-latest, head)
- GitHub Check: test (windows-latest, head)
- GitHub Check: test (macos-latest, 2.6)
- GitHub Check: test (windows-latest, 3.1)
- GitHub Check: test (windows-latest, 3.0)
- GitHub Check: test (macos-latest, 2.7)
- GitHub Check: test (ubuntu-latest, 2.6)
- GitHub Check: test (ubuntu-latest, 2.7)
🔇 Additional comments (1)
README.md (1)
3-6: Excellent addition to improve project professionalism.The three badges are well-chosen and align with the PR objectives. The License, Gem Version, and CI workflow badges provide clear, at-a-glance status indicators. The placement at the top of the README before the main description follows standard conventions used in quality open-source projects (as noted in the PR description comparing to react_on_rails and shakapacker).
| [](LICENSE.md) | ||
| [](https://badge.fury.io/rb/package_json) | ||
| [](https://github.com/shakacode/package_json/actions/workflows/checks.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify badge target files exist before merging.
The badges reference LICENSE.md and the GitHub Actions workflow checks.yml. Please confirm these files exist in the repository, as broken badge links would negatively impact the README's professional appearance.
🏁 Script executed:
#!/bin/bash
# Verify that LICENSE.md and the GitHub Actions workflow file exist
echo "=== Checking LICENSE.md ==="
if [ -f "LICENSE.md" ]; then
echo "✓ LICENSE.md found"
else
echo "✗ LICENSE.md NOT found"
fi
echo ""
echo "=== Checking GitHub Actions workflow ==="
if [ -f ".github/workflows/checks.yml" ]; then
echo "✓ .github/workflows/checks.yml found"
else
echo "✗ .github/workflows/checks.yml NOT found"
# Check for any existing workflows
echo "Existing workflows:"
find .github/workflows -type f 2>/dev/null | head -5 || echo " (no workflows directory)"
fiLength of output: 129
---
🏁 Script executed:
```shell
#!/bin/bash
# Check for any LICENSE files in the repository root
echo "=== Searching for LICENSE files in repository root ==="
find . -maxdepth 1 -iname "LICENSE*" -type f 2>/dev/null | sort
echo ""
echo "=== Checking common license file names ==="
for file in LICENSE LICENSE.md LICENSE.txt LICENSE.rst COPYING COPYING.md LICENCE LICENCE.md; do
if [ -f "$file" ]; then
echo "✓ Found: $file"
fi
done
Length of output: 133
Fix broken LICENSE badge link: change LICENSE.md to LICENSE.txt on line 3.
The LICENSE badge references LICENSE.md, but the repository contains LICENSE.txt. Update the badge URL to reference the correct file to prevent a broken link.
🤖 Prompt for AI Agents
In README.md around lines 3 to 5, the license badge link points to LICENSE.md
which does not exist in the repo; update the badge URL to reference LICENSE.txt
instead so the badge links to the correct file.
Summary
Makes the README more professional and consistent with other ShakaCode projects like react_on_rails and shakapacker.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit