-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup for 2.0.0 Release #17
Conversation
…o source after building the gem
i think the only major thing is the renaming |
@grantspeelman you are right, is there a reason to keep the Happy to break it into smaller PRs that can be merged more quickly as well |
@yagudaev I don't see any reason to rush the remove of |
@@ -1,3 +1 @@ | |||
require 'cypress_dev' | |||
|
|||
Cypress = CypressDev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grantspeelman would it be enough to have
CypressDev = CypressOnRails
In here to maintain backward compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, saw #19 it should pave the way for this and I can then cleanup and rebase this PR
Hi @grantspeelman and @yagudaev, where do we stand with this PR? Should we close it? or update to master? @yagudaev are you using the code from this branch in production? |
The rename has already been done on master. |
@yagudaev anything we should merge here? Or close this? |
I'm closing this for now. I'd like to move our code base at work to using origin again. You guys have done a fantastic job. We have also learned a lot since we started using Cypress. |
This is still a work-in-progress and started as a bit of a spike to see if I can fix the security concerns with allowing arbitrary code execution. #13
I'm adding this PR here as a way to start a conversation about the direction we want for a 2.0.0 release and outline what we as a community want to see there.
Changes
Cypress
andCypressDev
namespaces and consolidate things underCypressOnRails
I marked this as an Alpha since my team is actually using this for our testing with cypress.
Now that I think about it more, would you be open to create a 2.0.0 branch and a tag for issues we want to see on a 2.0.0 release? The main reason this has to be in a major version release is that it breaks backward compatibility to make things cleaner. We can even add deprecation messages to next minor releases to encourage existing users to change.
Thoughts?