-
Notifications
You must be signed in to change notification settings - Fork 5
[codex] Document Grafana and OpenTelemetry on Control Plane #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justin808
wants to merge
20
commits into
main
Choose a base branch
from
docs/grafana-opentelemetry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+620
−5
Open
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a67f7a7
Document Grafana and OpenTelemetry on Control Plane
justin808 7a7a87a
Merge remote-tracking branch 'origin/main' into docs/grafana-opentele…
justin808 91ec978
Address Grafana OpenTelemetry docs review
justin808 d7b6ed2
Clarify OpenTelemetry guide examples
justin808 9382d3c
Use standard OTel endpoint in guide
justin808 0c75adc
Tighten collector guide examples
justin808 b15fb5e
Clarify OpenTelemetry rollout guide
justin808 a185feb
Address rollout guide review notes
justin808 0df9d21
Tighten collector guide examples
justin808 c18c9ae
Clarify collector validation guidance
justin808 3c44c92
Clarify spanmetrics validation notes
justin808 0bb5821
Merge remote-tracking branch 'origin/main' into docs/grafana-opentele…
justin808 8e8cca3
Clarify OpenTelemetry initializer example
justin808 400e784
Clarify OpenTelemetry collector and initializer edge cases
justin808 f6e4a19
Document collector pipeline wiring and copy-paste safety notes
justin808 4b9271e
Fix OTLP default port and IsRootSpan version in OpenTelemetry guide
justin808 fe992df
Simplify OpenTelemetry guide and add cross-links to existing docs
justin808 62ed600
Address OpenTelemetry guide review: env contradiction, hashing, sampl…
justin808 c00658d
Keep status.code as a spanmetrics dimension so error rate is derivable
justin808 4596591
Add batch to traces pipeline and an alert for a no-op filter
justin808 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -554,7 +554,7 @@ cpflow terraform import | |
| Regenerates the generated cpflow GitHub Actions wrappers and helper files | ||
| from the currently installed cpflow gem. Use this after updating the | ||
| cpflow gem so checked-in workflow wrappers move to the matching upstream | ||
| release tag, for example `v5.1.0`. | ||
| release tag, for example `v5.1.1`. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This version bump from |
||
|
|
||
| If the existing generated staging workflow uses a custom single staging | ||
| branch, the command preserves it. Pass `--staging-branch BRANCH` to set or | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.