Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I would like to add two-dimensional arrays to the Value type #275

Merged
merged 2 commits into from May 18, 2024

Conversation

maronnjapan
Copy link
Contributor

@maronnjapan maronnjapan commented Feb 9, 2024

I would like the Value type to accept two-dimensional arrays.
In the sample of the Multiple Range Picker in the document , it is configured to work with a two-dimensional array.
However, in the index.d.ts file, the type is only allowed for one-dimensional arrays, and under TypeScript, you can't use it without asserting the type with as.
Since I don't want to use assertions, I have submitted a pull request adding the type for two-dimensional arrays.
Thank you for your consideration.

I have added support for two-dimensional arrays to the Value type.
@maronnjapan
Copy link
Contributor Author

I'm sorry.
There was an mistake in the code I provided, so I fixed it.

@shahabyazdi shahabyazdi merged commit 59d7a28 into shahabyazdi:master May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants