Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: I changed cursor to pointer in dropDownMenuItem for improved usability. #3596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

L3on06
Copy link

@L3on06 L3on06 commented Apr 25, 2024

I optimized the cursor on the dropdown menu item, changing it from the default to a pointer. This enhances the user experience and follows standard practices for improved usability.

OLD

OLD.mov

NEW

NEW.mov

Copy link

vercel bot commented Apr 25, 2024

@L3on06 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@ruru-m07 ruru-m07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this little changes important?

@L3on06
Copy link
Author

L3on06 commented Apr 25, 2024

Absolutely! Even seemingly small changes like optimizing the cursor on a dropdown menu item can have a significant impact on user experience. By changing it to a pointer, you're providing users with a visual cue that the item is clickable, which can lead to better navigation and interaction. These attention to detail demonstrates a commitment to enhancing usability and adhering to established standards, ultimately contributing to a more polished and user-friendly interface. So yes, these changes are indeed important for improving the overall quality of the product.

@gurisko
Copy link

gurisko commented Apr 25, 2024

I agree with merging this since it fixes wrong UX pattern in UI kit public presentation.

@ruru-m07 What would be the blocker of not merging such a straightforward improvement?

@L3on06
Copy link
Author

L3on06 commented Apr 25, 2024

@gurisko Thanks, Gurisko! Your support means a lot, Appreciate it!

@ruru-m07
Copy link

I agree with merging this since it fixes wrong UX pattern in UI kit public presentation.

@ruru-m07 What would be the blocker of not merging such a straightforward improvement?

Mostly @shadcn merge PRs

@frederikmartin
Copy link

Same applies for components like SelectItem and CommandItem. Maybe a good idea (once this PR is merged) to check the components for similar UX issues.

@L3on06
Copy link
Author

L3on06 commented May 3, 2024

@frederikmartin Sure, I'm also working on that part. I'll submit a pull request as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants